linux-kernel - Re: [PATCH] cgroup/cpuset: fmeter_getrate() returns 0 when cpuset.memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <y77ijz3fimrjvt4tbnbfsa3jm74ttobdxqvh4q4bblc474h3kb@57qsirzrwply>
Date: Fri, 3 Jan 2025 17:47:57 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Jin Guojie <guojie.jin@...il.com>
Cc: Waiman Long <longman@...hat.com>, cgroups@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup/cpuset: fmeter_getrate() returns 0 when
 cpuset.memory_pressure disabled

On Thu, Dec 19, 2024 at 05:06:31PM +0800, Jin Guojie <guojie.jin@...il.com> wrote:
> According to admin-guide/cgroup-v1/cpusets.rst,
> 
> "1.5 What is memory_pressure ?
>  ...
>   So only systems that enable this feature
>   (i.e. memory_pressure_enabled) will compute the metric."
> 
> To be consistent with the documentation, when memory_pressure_enabled is 0,
> cpuset.memory_pressure should always returns 0.

IMO a clearer fix would be to call fmeter_init() (again) when writing 1
to the memory_pressure_enabled.
At the same time, the docs interpretation is lose in what should be
shown (e.g. show last value, don't calculate updates), so it may need no
fix.

HTH,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)