linux-kernel - Re: [PATCH 1/1] iommu/amd: remove return value of amd_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <F665D3C5-52B3-48A2-A256-0676C2A3E419@baidu.com>
Date: Fri, 3 Jan 2025 16:53:31 +0000
From: "Gao,Shiyuan" <gaoshiyuan@...du.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "joro@...tes.org"
	<joro@...tes.org>, "suravee.suthikulpanit@....com"
	<suravee.suthikulpanit@....com>, "will@...nel.org" <will@...nel.org>,
	"robin.murphy@....com" <robin.murphy@....com>
CC: "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Gao,Shiyuan"
	<gaoshiyuan@...du.com>
Subject: Re: [PATCH 1/1] iommu/amd: remove return value of amd_iommu_detect

> > The return value of amd_iommu_detect is not used, so remove it and
> > is consistent with other iommu detect functions.
> >
> > Signed-off-by: Gao Shiyuan <gaoshiyuan@...du.com <mailto:gaoshiyuan@...du.com>>
> > ---
> > drivers/iommu/amd/init.c | 10 +++++-----
> > include/linux/amd-iommu.h | 4 ++--
> > 2 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> > index 0e0a531042ac..98a42f3f9e53 100644
> > --- a/drivers/iommu/amd/init.c
> > +++ b/drivers/iommu/amd/init.c
> > @@ -3398,25 +3398,25 @@ static bool amd_iommu_sme_check(void)
> > * IOMMUs
> > *
> > ****************************************************************************/
> > -int __init amd_iommu_detect(void)
> > +void __init amd_iommu_detect(void)
> > {
> > int ret;
> >
> > if (no_iommu || (iommu_detected && !gart_iommu_aperture))
> > - return -ENODEV;
> > + return;
> >
> > if (!amd_iommu_sme_check())
> > - return -ENODEV;
> > + return;
> >
> > ret = iommu_go_to_state(IOMMU_IVRS_DETECTED);
> > if (ret)
> > - return ret;
> > + return;
> >
> > amd_iommu_detected = true;
> > iommu_detected = 1;
> > x86_init.iommu.iommu_init = amd_iommu_init;
> >
> > - return 1;
> > + return;
>
>
> This return is not needed any more.

Thanks, will remove it.