linux-kernel - Re: [PATCH] cpufreq/amd-pstate: Fix per-policy boost flag incorrect when fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e777177-417e-41eb-81d0-3635769d3a83@amd.com>
Date: Fri, 3 Jan 2025 10:56:34 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Lifeng Zheng <zhenglifeng1@...wei.com>, rafael@...nel.org,
 viresh.kumar@...aro.org, perry.yuan@....com
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linuxarm@...wei.com, jonathan.cameron@...wei.com, zhanjie9@...ilicon.com,
 lihuisong@...wei.com, fanghao11@...wei.com
Subject: Re: [PATCH] cpufreq/amd-pstate: Fix per-policy boost flag incorrect
 when fail

On 1/3/2025 01:41, Lifeng Zheng wrote:
> Commit c8c68c38b56f ("cpufreq: amd-pstate: initialize core precision
> boost state") sets per-policy boost flag to false when boost fail.
> However, this boost flag will be set to reverse value in
> store_local_boost() and cpufreq_boost_trigger_state() in cpufreq.c. This
> will cause the per-policy boost flag set to true when fail to set boost.
> Remove the extra assignment in amd_pstate_set_boost() and keep all
> operations on per-policy boost flag outside of set_boost() to fix this
> problem.
> 
> Fixes: c8c68c38b56f ("cpufreq: amd-pstate: initialize core precision boost state")
> Signed-off-by: Lifeng Zheng <zhenglifeng1@...wei.com>
> ---

Hi There,

Thanks for the patch.  Unfortunately, it doesn't apply to the current 
linux-next branch at 
https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git

Although the issue you identified is still valid, there have been other 
contextual changes in the function [1].  Can you rebase on that branch, 
test it again and send a v2?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git/tree/drivers/cpufreq/amd-pstate.c?h=linux-next#n750

Thanks!

>   drivers/cpufreq/amd-pstate.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 66e5dfc711c0..4ce923788f3a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -730,7 +730,6 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
>   	mutex_lock(&amd_pstate_driver_lock);
>   	ret = amd_pstate_cpu_boost_update(policy, state);
>   	WRITE_ONCE(cpudata->boost_state, !ret ? state : false);
> -	policy->boost_enabled = !ret ? state : false;
>   	refresh_frequency_limits(policy);
>   	mutex_unlock(&amd_pstate_driver_lock);
>