linux-kernel - Re: [PATCH 2/4] dt-bindings: mfd: syscon: allow two reg regions for gs101-pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce9408aa-96a4-498d-8603-01534d9632a2@kernel.org>
Date: Fri, 3 Jan 2025 18:14:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Griffin <peter.griffin@...aro.org>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 tudor.ambarus@...aro.org, andre.draszik@...aro.org, willmcvicker@...gle.com,
 kernel-team@...roid.com
Subject: Re: [PATCH 2/4] dt-bindings: mfd: syscon: allow two reg regions for
 gs101-pmu

On 30/12/2024 10:10, Peter Griffin wrote:
> 
>>
>> Maybe you have here two devices, maybe only one. If it is only one, then
>> it is not a syscon anymore, IMO.
> 
> I was going to suggest modelling PMU_INTR_GEN as its own sycon node,
> and then either: -
> 
> 1) Updating exynos-pmu driver to additionally take a phandle to
> pmu-intr-gen syscon, and register the hotplug callbacks.
> 
> or
> 
> 2) Create a new driver named something like exynos-pm or exynos-cpupm
> which obtains the PMU regmap and also a phandle to PMU_INTR_GEN
> syscon, and register the call backs.
> 
> Is there any preference from your side over approach 1 or 2, or maybe
> something else entirely?

No preference, choose whatever results in simpler or more readable code.

Option 1 assumes that exynos-pmu on GS101 will drop the "syscon"
compatible, although it still might expose syscon through drivers. Just
the standard binding syscon does not feel fit here.

I don't have the hardware/user manual, so I don't know what PMU_INTR_GEN
really is. GS downstream code has something like PMUCAL, which looks
like separate device.

Best regards,
Krzysztof