linux-kernel - Re: drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3gkY2vbLSgrbWaj@pc636>
Date: Fri, 3 Jan 2025 18:54:43 +0100
From: Uladzislau Rezki <urezki@...il.com>
To: Todd Kjos <tkjos@...roid.com>
Cc: Uladzislau Rezki <uladzislau.rezki@...y.com>,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...nel.org>,
	"Uladzislau Rezki (Sony)" <urezki@...il.com>
Subject: Re: drivers/android/binder.c:1819: warning: Function parameter or
 struct member 'file' not described in 'binder_task_work_cb'

On Fri, Jan 03, 2025 at 03:39:37PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
> commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT
> date:   2 years, 8 months ago
> config: csky-randconfig-r022-20230522 (https://download.01.org/0day-ci/archive/20250103/202501031535.erbln3A2-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/202501031535.erbln3A2-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/android/binder.c:233: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock'
>    drivers/android/binder.c:233: warning: Excess function parameter 'proc' description in 'binder_proc_unlock'
>    drivers/android/binder.c:335: warning: expecting prototype for binder_node_unlock(). Prototype was for binder_node_inner_unlock() instead
>    drivers/android/binder.c:1155: warning: expecting prototype for binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
> >> drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
> >> drivers/android/binder.c:1819: warning: Excess struct member 'fd' description in 'binder_task_work_cb'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
>    drivers/android/binder.c:2683: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn'
>    drivers/android/binder.c:2683: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn'
> >> drivers/android/binder.c:3510: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
> 
> 
> vim +1819 drivers/android/binder.c
> 
> 7980240b6d63e0 Martijn Coenen 2017-02-03  1806  
> 80cd795630d652 Todd Kjos      2018-12-14  1807  /**
> 80cd795630d652 Todd Kjos      2018-12-14  1808   * struct binder_task_work_cb - for deferred close
> 80cd795630d652 Todd Kjos      2018-12-14  1809   *
> 80cd795630d652 Todd Kjos      2018-12-14  1810   * @twork:                callback_head for task work
> 80cd795630d652 Todd Kjos      2018-12-14  1811   * @fd:                   fd to close
> 80cd795630d652 Todd Kjos      2018-12-14  1812   *
> 80cd795630d652 Todd Kjos      2018-12-14  1813   * Structure to pass task work to be handled after
> 80cd795630d652 Todd Kjos      2018-12-14  1814   * returning from binder_ioctl() via task_work_add().
> 80cd795630d652 Todd Kjos      2018-12-14  1815   */
> 80cd795630d652 Todd Kjos      2018-12-14  1816  struct binder_task_work_cb {
> 80cd795630d652 Todd Kjos      2018-12-14  1817  	struct callback_head twork;
> 80cd795630d652 Todd Kjos      2018-12-14  1818  	struct file *file;
> 80cd795630d652 Todd Kjos      2018-12-14 @1819  };
> 80cd795630d652 Todd Kjos      2018-12-14  1820  
> 
> :::::: The code at line 1819 was first introduced by commit
> :::::: 80cd795630d6526ba729a089a435bf74a57af927 binder: fix use-after-free due to ksys_close() during fdget()
> 
Above warnings have nothing to do with the:

    commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT

Add "Todd Kjos <tkjos@...roid.com>", owner of the patch, to sort those warnings out. 

--
Uladzislau Rezki