linux-kernel - Re: [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak functions to available_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3gnHGhNKOT7P4Ga@krava>
Date: Fri, 3 Jan 2025 19:06:20 +0100
From: Jiri Olsa <olsajiri@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Jiri Olsa <olsajiri@...il.com>,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, bpf <bpf@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Zheng Yejian <zhengyejian1@...wei.com>,
	Martin Kelly <martin.kelly@...wdstrike.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak
 functions to available_filter_functions

On Fri, Jan 03, 2025 at 07:14:09AM -0500, Steven Rostedt wrote:
> On Fri, 3 Jan 2025 12:41:40 +0100
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> >  
> > > not sure why that fits the condition above for removal  
> > 
> > Check your build, if update_socket_protocol() is no longer in the symbol
> > table for your vmlinux.o then the linker deleted the symbol and things
> > work as advertised.
> > 
> > If its still there, these patches have a wobbly.
> 
> There is a wobbly. I guess I eliminated all weak functions even if they
> were still used :-p
> 
> Jiri, can you add this on top?

yes, that fixed that

thanks,
jirka

> 
> diff --git a/scripts/sorttable.c b/scripts/sorttable.c
> index 506172898fd8..ebcd687a9f0e 100644
> --- a/scripts/sorttable.c
> +++ b/scripts/sorttable.c
> @@ -523,7 +523,7 @@ static int parse_symbols(const char *fname)
>  		uint64_t size;
>  
>  		/* Only care about functions */
> -		if (type != 't' && type != 'T')
> +		if (type != 't' && type != 'T' && type != 'W')
>  			continue;
>  
>  		addr = strtoull(addr_str, NULL, 16);
> 
> 
> -- Steve