linux-kernel - Re: [PATCH v2] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250103100737.1f329212@kernel.org>
Date: Fri, 3 Jan 2025 10:07:37 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, Su Hui
 <suhui@...china.com>
Cc: alexanderduyck@...com, kernel-team@...a.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, mohsin.bashr@...il.com, sanmanpradhan@...a.com,
 kalesh-anakkur.purayil@...adcom.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] eth: fbnic: Avoid garbage value in
 fbnic_mac_get_sensor_asic()

On Mon, 30 Dec 2024 08:52:49 -0800 Jakub Kicinski wrote:
> > It is more like removing broken functionality than fixing (maybe whole
> > commit should be reverted). Anyway returning not support is also fine.  
> 
> I defer to other maintainers. The gaps are trivial to fill in, we'll 
> do so as soon as this patch makes it to net-next (this patch needs to
> target net).

Having slept on it, I think you're right.

Su Hui, could you send a revert of d85ebade02e8 instead?
It's around 126 LoC, not too bad.