linux-kernel - Re: [PATCH 13/14] PCI: hv: switch hv_compose_multi_msi_req_get_cpu() to using cpumask_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3gy14tcnwCEDckC@yury-ThinkPad>
Date: Fri, 3 Jan 2025 10:56:23 -0800
From: Yury Norov <yury.norov@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH 13/14] PCI: hv: switch hv_compose_multi_msi_req_get_cpu()
 to using cpumask_next_wrap()

On Fri, Jan 03, 2025 at 11:45:43AM -0600, Bjorn Helgaas wrote:
> On Sat, Dec 28, 2024 at 10:49:45AM -0800, Yury Norov wrote:
> > Calling cpumask_next_wrap_old() with starting CPU == nr_cpu_ids
> > is effectively the same as request to find first CPU, starting
> > from a given one and wrapping around if needed.
> > 
> > cpumask_next_wrap() is a proper replacement for that.
> > 
> > Signed-off-by: Yury Norov <yury.norov@...il.com>
> 
> s/switch/Switch/ in subject to match history.
> 
> Since this depends on previous patches, I assume you'll merge them all
> together, so:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

Hi Bjorn,

Thanks for review!

Agree with everything you spotted out. I'll fix it in v2 if it will be
needed, or inplace when applying.

Thanks,
Yury