linux-kernel - Re: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3g0MLOJlLsPnF1m@skv.local>
Date: Fri, 3 Jan 2025 22:02:08 +0300
From: Andrey Skvortsov <andrej.skvortzov@...il.com>
To: Vasily Khoruzhick <anarsoul@...il.com>
Cc: Ping-Ke Shih <pkshih@...ltek.com>, Kalle Valo <kvalo@...nel.org>,
	Fiona Klute <fiona.klute@....de>,
	Bitterblue Smith <rtl8821cerfe2@...il.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

On 25-01-02 23:50, Vasily Khoruzhick wrote:
> Fix 3 typos in 8703b driver. 2 typos in calibration routines are not
> fatal and do not seem to have any impact, just fix them to match vendor
> driver.
> 
> However the last one in rtw8703b_set_channel_bb() clears too many bits
> in REG_OFDM0_TX_PSD_NOISE, causing TX and RX issues (neither rate goes
> above MCS0-MCS1). Vendor driver clears only 2 most significant bits.
> 
> With the last typo fixed, the driver is able to reach MCS7 on Pinebook
> 
> Cc: stable@...r.kernel.org
> Fixes: 9bb762b3a957 ("wifi: rtw88: Add definitions for 8703b chip")
> Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>

Tested-by: Andrey Skvortsov <andrej.skvortzov@...il.com>

Thank you, Vasily, for fixing that. Performance is much better with
the fix. Here are iperf results made on PinePhone:

1. without the patch using rtw88 driver
  1.98 Mbits/sec

2. with the patch using rtw88 driver
  14.0 Mbits/sec

3. using old vendor 8723cs driver
  23.6 Mbits/sec

 
-- 
Best regards,
Andrey Skvortsov