linux-kernel - Re: [PATCH v2] tools: perf: tests: Fix code reading for riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3g3SrBwQcXWdbRr@ghost>
Date: Fri, 3 Jan 2025 11:15:22 -0800
From: Charlie Jenkins <charlie@...osinc.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2] tools: perf: tests: Fix code reading for riscv

On Fri, Jan 03, 2025 at 01:51:59PM -0300, Arnaldo Carvalho de Melo wrote:
> On Thu, Jan 02, 2025 at 05:44:56PM -0800, Charlie Jenkins wrote:
> > On Wed, Dec 18, 2024 at 05:52:24PM -0800, Charlie Jenkins wrote:
> > > On Wed, Dec 18, 2024 at 05:20:15PM -0800, Ian Rogers wrote:
> > > Yeah I agree. This test case did end up being interesting though as it
> > > unconvered this change in behavior of objdump on riscv, but that's
> > > tangential to the purpose of this test case. We need this patch on riscv
> > > to stop this test from failing, but it is also reasonable to approach
> > > this differently and not use objdump at all.
>  
> > What's the next step here? Would you prefer to get rid of this test
> > entirely? I sent out a v3 that uses uname [1].
>  
> > Link
> > https://lore.kernel.org/lkml/20241219-perf_fix_riscv_obj_reading-v3-1-a7d644dcfa50@rivosinc.com/
> > [1]
> 
> I'm ok with this latest version and added it to perf-tools-next,
> changing the patch subject line to:
> 
>   perf tests code-reading: Handle change in objdump output from binutils >= 2.41 on riscv
> 
> Ok?

Yes that is perfect, thank you!

- Charlie

> 
> - Arnaldo