linux-kernel - Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3g4M-r5TKOAEHyU@gourry-fedora-PF4VCD3F>
Date: Fri, 3 Jan 2025 14:19:15 -0500
From: Gregory Price <gourry@...rry.net>
To: Donet Tom <donettom@...ux.ibm.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, nehagholkar@...a.com,
	abhishekd@...a.com, kernel-team@...a.com, david@...hat.com,
	nphamcs@...il.com, akpm@...ux-foundation.org, hannes@...xchg.org,
	kbusch@...a.com, ying.huang@...ux.alibaba.com
Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints

On Fri, Jan 03, 2025 at 03:48:24PM +0530, Donet Tom wrote:
> 
> On 12/11/24 03:07, Gregory Price wrote:
> > Count non-page-fault events as page-cache numa hints instead of
> > fault hints in vmstat. Add a define to select the hint type to
> > keep the code clean.
> > 
> > Signed-off-by: Gregory Price <gourry@...rry.net>
> > ---
> >   include/linux/vm_event_item.h | 8 ++++++++
> >   mm/memory.c                   | 6 +++---
> >   mm/vmstat.c                   | 2 ++
> >   3 files changed, 13 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
> > index f70d0958095c..c5abb0f7cca7 100644
> > --- a/include/linux/vm_event_item.h
> > +++ b/include/linux/vm_event_item.h
> > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
> >   		NUMA_HUGE_PTE_UPDATES,
> >   		NUMA_HINT_FAULTS,
> >   		NUMA_HINT_FAULTS_LOCAL,
> > +		NUMA_HINT_PAGE_CACHE,
> Hi Gregory,
> 
> While running tests on the patch, I encountered the following warning
> message on the console.
> 

Thank you for catching this, will add to v3.

v3 is coming soon with more microbenchmark info, then hopefully moving
on to some workload testing.

~Gregory