linux-kernel - Re: [PATCH] ipmi: ssif_bmc: Move smbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3dXaMlZ1zTt5HHd@mail.minyard.net>
Date: Thu, 2 Jan 2025 21:20:08 -0600
From: Corey Minyard <corey@...yard.net>
To: Cosmo Chou <chou.cosmo@...il.com>
Cc: minyard@....org, quan@...amperecomputing.com,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, cosmo.chou@...ntatw.com,
	potin.lai@...ntatw.com
Subject: Re: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup

On Thu, Jan 02, 2025 at 12:54:31AM +0800, Cosmo Chou wrote:
> Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
> the new command is not lost when complete_response() is triggered.

Ok, I see, patch is applied.  Thank you.

Quan, I assume this is ok.  Please double-check it for me.

-corey

> 
> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
> Signed-off-by: Cosmo Chou <chou.cosmo@...il.com>
> ---
>  drivers/char/ipmi/ssif_bmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index a14fafc583d4..7a4f52987a7d 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -579,7 +579,6 @@ static void process_request_part(struct ssif_bmc_ctx *ssif_bmc)
>  static void process_smbus_cmd(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
>  {
>  	/* SMBUS command can vary (single or multi-part) */
> -	ssif_bmc->part_buf.smbus_cmd = *val;
>  	ssif_bmc->msg_idx = 1;
>  	memset(&ssif_bmc->part_buf.payload[0], 0, MAX_PAYLOAD_PER_TRANSACTION);
>  
> @@ -596,6 +595,7 @@ static void process_smbus_cmd(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
>  		if (ssif_bmc->aborting)
>  			ssif_bmc->aborting = false;
>  	}
> +	ssif_bmc->part_buf.smbus_cmd = *val;
>  }
>  
>  static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
> -- 
> 2.34.1
>