| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Z3j0uC5d/bSHof3s@rli9-mobl>
Date: Sat, 4 Jan 2025 16:43:36 +0800
From: Philip Li <philip.li@...el.com>
To: kernel test robot <lkp@...el.com>
CC: Uladzislau Rezki <uladzislau.rezki@...y.com>,
<oe-kbuild-all@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, "Paul E.
McKenney" <paulmck@...nel.org>, "Uladzislau Rezki (Sony)" <urezki@...il.com>
Subject: Re: drivers/android/binderfs.c:235: warning: Function parameter or
struct member 'file' not described in 'binder_ctl_ioctl'
On Sat, Jan 04, 2025 at 02:17:23PM +0800, kernel test robot wrote:
> Hi Uladzislau,
>
> First bad commit (maybe != root cause):
Hi Uladzislau, sorry, kindly ignore this false report. This has been discussed in [1]
already that the commit is not the actual cause.
[1] https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 63676eefb7a026d04b51dcb7aaf54f358517a2ec
> commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT
> date: 2 years, 8 months ago
> config: csky-randconfig-r036-20230303 (https://download.01.org/0day-ci/archive/20250104/202501041430.6u1qEegs-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250104/202501041430.6u1qEegs-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501041430.6u1qEegs-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/android/binderfs.c:235: warning: Function parameter or struct member 'file' not described in 'binder_ctl_ioctl'
> >> drivers/android/binderfs.c:235: warning: Function parameter or struct member 'cmd' not described in 'binder_ctl_ioctl'
> >> drivers/android/binderfs.c:235: warning: Function parameter or struct member 'arg' not described in 'binder_ctl_ioctl'
> drivers/android/binderfs.c:235: warning: expecting prototype for binderfs_ctl_ioctl(). Prototype was for binder_ctl_ioctl() instead
> --
> drivers/android/binder.c:233: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock'
> drivers/android/binder.c:233: warning: Excess function parameter 'proc' description in 'binder_proc_unlock'
> drivers/android/binder.c:335: warning: expecting prototype for binder_node_unlock(). Prototype was for binder_node_inner_unlock() instead
> drivers/android/binder.c:1155: warning: expecting prototype for binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
> >> drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
> >> drivers/android/binder.c:1819: warning: Excess struct member 'fd' description in 'binder_task_work_cb'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'
> >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
> drivers/android/binder.c:2683: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn'
> drivers/android/binder.c:2683: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn'
> >> drivers/android/binder.c:3510: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
>
>
> vim +235 drivers/android/binderfs.c
>
> 3ad20fe393b310 Christian Brauner 2018-12-14 222
> 3ad20fe393b310 Christian Brauner 2018-12-14 223 /**
> 3ad20fe393b310 Christian Brauner 2018-12-14 224 * binderfs_ctl_ioctl - handle binder device node allocation requests
> 3ad20fe393b310 Christian Brauner 2018-12-14 225 *
> 3ad20fe393b310 Christian Brauner 2018-12-14 226 * The request handler for the binder-control device. All requests operate on
> 3ad20fe393b310 Christian Brauner 2018-12-14 227 * the binderfs mount the binder-control device resides in:
> 3ad20fe393b310 Christian Brauner 2018-12-14 228 * - BINDER_CTL_ADD
> 3ad20fe393b310 Christian Brauner 2018-12-14 229 * Allocate a new binder device.
> 3ad20fe393b310 Christian Brauner 2018-12-14 230 *
> 3ad20fe393b310 Christian Brauner 2018-12-14 231 * Return: 0 on success, negative errno on failure
> 3ad20fe393b310 Christian Brauner 2018-12-14 232 */
> 3ad20fe393b310 Christian Brauner 2018-12-14 233 static long binder_ctl_ioctl(struct file *file, unsigned int cmd,
> 3ad20fe393b310 Christian Brauner 2018-12-14 234 unsigned long arg)
> 3ad20fe393b310 Christian Brauner 2018-12-14 @235 {
> 3ad20fe393b310 Christian Brauner 2018-12-14 236 int ret = -EINVAL;
> 3ad20fe393b310 Christian Brauner 2018-12-14 237 struct inode *inode = file_inode(file);
> 3ad20fe393b310 Christian Brauner 2018-12-14 238 struct binderfs_device __user *device = (struct binderfs_device __user *)arg;
> 3ad20fe393b310 Christian Brauner 2018-12-14 239 struct binderfs_device device_req;
> 3ad20fe393b310 Christian Brauner 2018-12-14 240
> 3ad20fe393b310 Christian Brauner 2018-12-14 241 switch (cmd) {
> 3ad20fe393b310 Christian Brauner 2018-12-14 242 case BINDER_CTL_ADD:
> 3ad20fe393b310 Christian Brauner 2018-12-14 243 ret = copy_from_user(&device_req, device, sizeof(device_req));
> 3ad20fe393b310 Christian Brauner 2018-12-14 244 if (ret) {
> 3ad20fe393b310 Christian Brauner 2018-12-14 245 ret = -EFAULT;
> 3ad20fe393b310 Christian Brauner 2018-12-14 246 break;
> 3ad20fe393b310 Christian Brauner 2018-12-14 247 }
> 3ad20fe393b310 Christian Brauner 2018-12-14 248
> 3ad20fe393b310 Christian Brauner 2018-12-14 249 ret = binderfs_binder_device_create(inode, device, &device_req);
> 3ad20fe393b310 Christian Brauner 2018-12-14 250 break;
> 3ad20fe393b310 Christian Brauner 2018-12-14 251 default:
> 3ad20fe393b310 Christian Brauner 2018-12-14 252 break;
> 3ad20fe393b310 Christian Brauner 2018-12-14 253 }
> 3ad20fe393b310 Christian Brauner 2018-12-14 254
> 3ad20fe393b310 Christian Brauner 2018-12-14 255 return ret;
> 3ad20fe393b310 Christian Brauner 2018-12-14 256 }
> 3ad20fe393b310 Christian Brauner 2018-12-14 257
>
> :::::: The code at line 235 was first introduced by commit
> :::::: 3ad20fe393b31025bebfc2d76964561f65df48aa binder: implement binderfs
>
> :::::: TO: Christian Brauner <christian@...uner.io>
> :::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
Powered by blists - more mailing lists