linux-kernel - Re: [PATCH] platform/x86: acer-wmi: improve platform profile handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a9385e6-8c5a-4d08-8ff9-728ac40792d2@gmail.com>
Date: Sat, 4 Jan 2025 17:55:17 +0900
From: SungHwan Jung <onenowy@...il.com>
To: Armin Wolf <W_Armin@....de>, Hridesh MG <hridesh699@...il.com>,
 Kurt Borja <kuurtb@...il.com>
Cc: "Lee, Chun-Yi" <jlee@...e.com>, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] platform/x86: acer-wmi: improve platform profile handling



On 1/4/25 06:07, Armin Wolf wrote:

> That is some very important information right here. The platform-profile
> documentation states:
> 
>     "Specifically when selecting a high performance profile the actual
> achieved
>      performance may be limited by various factors such as: the heat
> generated
>      by other components, room temperature, free air flow at the bottom
> of a
>      laptop, etc. It is explicitly NOT a goal of this API to let
> userspace know
>      about any sub-optimal conditions which are impeding reaching the
> requested
>      performance level."
> 
> I think the AC handling is unnecessary in this case as the hardware
> seems to accept different profiles
> even when not running on AC. This would simplify the platform profile
> cycling inside the driver and
> allow us to use platform_profile_cycle().
> 
> I wonder if this special behavior of the acer-wmi driver is documented
> somewhere. I am asking this since
> this has a great potential to confuse users.
The acer_thermal_profile_change function was made for predator phn16-71
and tested with some predator laptop series.

These predator series have the mode button that toggles between turbo or
non-turbo or cycles each modes. And the predator sense app restricts
these predator series to Eco and Balanced mode on battery.
So this function includes on_AC to reflect these behaviors.(mentioned on
comments)

platform_profile_cycle() is suitable for cycle mode by
cycle_gaming_thermal_profile parameter and if there is no reason to
restrict thermal profiles on battery, we don't need to handle on_AC. But
I'm not sure why the manufacturer restricts the thermal profiles on
battery on windows.

Thanks,
SungHwan Jung
> 
> Thanks,
> Armin Wolf