linux-kernel - Re: [PATCH v2 1/4] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca0cad16-7c39-4635-8f09-f9f3c95c9fef@kernel.org>
Date: Sat, 4 Jan 2025 11:33:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: wens@...e.org, Vasily Khoruzhick <anarsoul@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jernej Skrabec
 <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Maxime Ripard <mripard@...nel.org>,
 Roman Beranek <me@...y.cz>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 Dragan Simic <dsimic@...jaro.org>, Frank Oltmanns <frank@...manns.dev>,
 Stuart Gathman <stuart@...hman.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and
 PLL_MIPI

On 04/01/2025 11:23, Chen-Yu Tsai wrote:
> On Sat, Jan 4, 2025 at 3:40 PM Vasily Khoruzhick <anarsoul@...il.com> wrote:
>>
>> Export PLL_VIDEO_2X and PLL_MIPI, these will be used to explicitly
>> select TCON0 clock parent in dts
>>
>> Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux")
>> Reviewed-by: Dragan Simic <dsimic@...jaro.org>
>> Reviewed-by: Chen-Yu Tsai <wens@...e.org>
>> Tested-by: Frank Oltmanns <frank@...manns.dev> # on PinePhone
>> Tested-by: Stuart Gathman <stuart@...hman.org> # on OG Pinebook
>> Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>
>> ---
>>  include/dt-bindings/clock/sun50i-a64-ccu.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h b/include/dt-bindings/clock/sun50i-a64-ccu.h
>> index 175892189e9d..4f220ea7a23c 100644
>> --- a/include/dt-bindings/clock/sun50i-a64-ccu.h
>> +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h
>> @@ -44,7 +44,9 @@
>>  #define _DT_BINDINGS_CLK_SUN50I_A64_H_
>>
>>  #define CLK_PLL_VIDEO0         7
>> +#define CLK_PLL_VIDEO0_2X      8
>>  #define CLK_PLL_PERIPH0                11
>> +#define CLK_PLL_MIPI           17
> 
> You can't really split code movement into two patches.
> 
> With this patch applied the clk driver will fail to build because
> the macros are now redefined in both header files.

Are you sure? The values seem the same to me... I don't see how this
could fail.

> 
> Barring recombining the patches, please add a patch before this
> adding #ifndef's around the two macros that are moved.
> 

No, not necessary, just churn,


Best regards,
Krzysztof