linux-kernel - Re: [PATCH v9 0/4] iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250104130916.5a25b5bd@jic23-huawei>
Date: Sat, 4 Jan 2025 13:09:16 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 eraretuya@...il.com
Subject: Re: [PATCH v9 0/4] iio: accel: adxl345: add FIFO operating with IRQ
 triggered watermark events

On Sat, 28 Dec 2024 23:29:45 +0000
Lothar Rubusch <l.rubusch@...il.com> wrote:

> The adxl345 sensor offers several features. Most of them are based on
> using the hardware FIFO and reacting on events coming in on an interrupt
> line. Add access to configure and read out the FIFO, handling of interrupts
> and configuration and application of the watermark feature on that FIFO.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
Series applied but with a tweak on patch 3.  Please take a look at the
testing branch where this will sit for a few days,

Jonathan

> ---
> v8 -> v9:
> - move FIELD_PREP() usage to a local usage in adxl345_core.c
> - remove ADXL345_{SD}_TAP_MSK macros
> v7 -> v8:
> - remove dt-binding quotation marks
> - add DMA alignment
> - fix indention, formatting and text alignment
> v6 -> v7:
> - reorder dt-binding patches
> - extracted FIFO specific from constants list
> - reorder constants list in header patch to the end
> - verify watermark input is within valid range
> v5 -> v6:
> - dropped justify patch, since unnecessary change to format mask
> - added separate dt-bindings patch to remove required interrupts property
> - merged FIFO watermark patches
> - reworked bitfield handling
> - group irq setup in probe()
> - several type fixes by smatch and tools
> v4 -> v5:
> - fix dt-binding for enum array of INT1 and INT2
> v3 -> v4:
> - fix dt-binding indention 
> v2 -> v3:
> - reorganize commits, merge the watermark handling
> - INT lines are defined by binding
> - kfifo is prepared by devm_iio_kfifo_buffer_setup()
> - event handler is registered w/ devm_request_threaded_irq()
> v1 -> v2:
> Fix comments according to Documentation/doc-guide/kernel-doc.rst
> and missing static declaration of function.
> ---
> Lothar Rubusch (4):
>   iio: accel: adxl345: introduce interrupt handling
>   iio: accel: adxl345: initialize FIFO delay value for SPI
>   iio: accel: adxl345: add FIFO with watermark events
>   iio: accel: adxl345: complete the list of defines
> 
>  drivers/iio/accel/adxl345.h      |  77 +++++--
>  drivers/iio/accel/adxl345_core.c | 338 ++++++++++++++++++++++++++++++-
>  drivers/iio/accel/adxl345_i2c.c  |   2 +-
>  drivers/iio/accel/adxl345_spi.c  |   7 +-
>  4 files changed, 404 insertions(+), 20 deletions(-)
>