Message-ID: <Z3lXguFBy-L1Z7Fj@krava>
Date: Sat, 4 Jan 2025 16:45:06 +0100
From: Jiri Olsa <olsajiri@...il.com>
To: syzbot <syzbot+091dd8c0495cc3c6b48d@...kaller.appspotmail.com>
Cc: andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
	daniel@...earbox.net, eddyz87@...il.com, haoluo@...gle.com,
	john.fastabend@...il.com, kpsingh@...nel.org,
	linux-kernel@...r.kernel.org, martin.lau@...ux.dev, sdf@...ichev.me,
	song@...nel.org, syzkaller-bugs@...glegroups.com,
	yonghong.song@...ux.dev
Subject: Re: [syzbot] [bpf?] WARNING: held lock freed in process_one_work

On Thu, Jan 02, 2025 at 05:24:22AM -0800, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    fd0584d220fe Merge tag 'trace-tools-v6.13-rc4' of git://gi..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=16bf90b0580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=c078001e66e4a17e
> dashboard link: https://syzkaller.appspot.com/bug?extid=091dd8c0495cc3c6b48d
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
> 
> Unfortunately, I don't have any reproducer for this issue yet.
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/ecc75c8807ba/disk-fd0584d2.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/0d5d397df783/vmlinux-fd0584d2.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/da7bfd7b8963/bzImage-fd0584d2.xz
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+091dd8c0495cc3c6b48d@...kaller.appspotmail.com
> 
> =========================
> WARNING: held lock freed!
> 6.13.0-rc4-syzkaller-00071-gfd0584d220fe #0 Not tainted
> -------------------------
> kworker/1:2/28505 is freeing memory 0000000000000000-ffffffffffffefff, with a lock still held there!

that address range looks wrong, too bad there's no reproducer

jirka


> ffff88801ac80948 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x12cd/0x1b30 kernel/workqueue.c:3204
> 2 locks held by kworker/1:2/28505:
>  #0: ffff88801ac80948 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x12cd/0x1b30 kernel/workqueue.c:3204
>  #1: ffffc900186f7d80 ((work_completion)(&aux->work)){+.+.}-{0:0}, at: process_one_work+0x8bb/0x1b30 kernel/workqueue.c:3205
> 
> stack backtrace:
> CPU: 1 UID: 0 PID: 28505 Comm: kworker/1:2 Not tainted 6.13.0-rc4-syzkaller-00071-gfd0584d220fe #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
> Workqueue: events bpf_prog_free_deferred
> Call Trace:
>  <TASK>
>  __dump_stack lib/dump_stack.c:94 [inline]
>  dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
>  print_freed_lock_bug kernel/locking/lockdep.c:6662 [inline]
>  debug_check_no_locks_freed+0x208/0x2b0 kernel/locking/lockdep.c:6697
>  remove_vm_area+0x128/0x3f0 mm/vmalloc.c:3240
>  vfree+0x90/0x950 mm/vmalloc.c:3364
>  bpf_prog_free_deferred+0x539/0x6f0 kernel/bpf/core.c:2820
>  process_one_work+0x958/0x1b30 kernel/workqueue.c:3229
>  process_scheduled_works kernel/workqueue.c:3310 [inline]
>  worker_thread+0x6c8/0xf00 kernel/workqueue.c:3391
>  kthread+0x2c1/0x3a0 kernel/kthread.c:389
>  ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
>  </TASK>
> ------------[ cut here ]------------
> ODEBUG: free active (active state 1) object: ffff88807a9a9100 object type: rcu_head hint: 0x0
> WARNING: CPU: 1 PID: 28505 at lib/debugobjects.c:612 debug_print_object+0x1a2/0x2b0 lib/debugobjects.c:612
> Modules linked in:
> 
> CPU: 1 UID: 0 PID: 28505 Comm: kworker/1:2 Not tainted 6.13.0-rc4-syzkaller-00071-gfd0584d220fe #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
> Workqueue: events bpf_prog_free_deferred
> 
> RIP: 0010:debug_print_object+0x1a2/0x2b0 lib/debugobjects.c:612
> Code: fc ff df 48 89 fa 48 c1 ea 03 80 3c 02 00 75 54 48 8b 14 dd e0 80 b1 8b 41 56 4c 89 e6 48 c7 c7 60 75 b1 8b e8 af 52 bc fc 90 <0f> 0b 90 90 58 83 05 f6 53 7f 0b 01 48 83 c4 18 5b 5d 41 5c 41 5d
> RSP: 0018:ffffc900186f7a08 EFLAGS: 00010282
> 
> RAX: 0000000000000000 RBX: 0000000000000003 RCX: ffffffff815a1729
> RDX: ffff8880655ebc00 RSI: ffffffff815a1736 RDI: 0000000000000001
> RBP: 0000000000000001 R08: 0000000000000001 R09: 0000000000000000
> R10: 0000000000000001 R11: 0000000000000001 R12: ffffffff8bb17c00
> R13: ffffffff8b4e5e20 R14: 0000000000000000 R15: ffffc900186f7b18
> FS:  0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007f78f559790a CR3: 000000006b8b2000 CR4: 00000000003526f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
>  <TASK>
>  __debug_check_no_obj_freed lib/debugobjects.c:1099 [inline]
>  debug_check_no_obj_freed+0x4b7/0x600 lib/debugobjects.c:1129
>  remove_vm_area+0x1ae/0x3f0 mm/vmalloc.c:3241
>  vfree+0x90/0x950 mm/vmalloc.c:3364
>  bpf_prog_free_deferred+0x539/0x6f0 kernel/bpf/core.c:2820
>  process_one_work+0x958/0x1b30 kernel/workqueue.c:3229
>  process_scheduled_works kernel/workqueue.c:3310 [inline]
>  worker_thread+0x6c8/0xf00 kernel/workqueue.c:3391
>  kthread+0x2c1/0x3a0 kernel/kthread.c:389
>  ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
>  </TASK>
> 
> 
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@...glegroups.com.
> 
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> 
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
> 
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
> 
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
> 
> If you want to undo deduplication, reply with:
> #syz undup

Powered by blists - more mailing lists