linux-kernel - drivers/ntb/msi.c:38: warning: Function parameter or struct member 'desc_changed' not described in 'ntb_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202501042317.rG3tE7M5-lkp@intel.com>
Date: Sat, 4 Jan 2025 23:46:11 +0800
From: kernel test robot <lkp@...el.com>
To: Logan Gunthorpe <logang@...tatee.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jon Mason <jdmason@...zu.us>
Subject: drivers/ntb/msi.c:38: warning: Function parameter or struct member
 'desc_changed' not described in 'ntb_msi_init'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   63676eefb7a026d04b51dcb7aaf54f358517a2ec
commit: 26b3a37b928457ba2cd98eaf6d7b0feca5a30fa6 NTB: Introduce MSI library
date:   6 years ago
config: alpha-randconfig-r025-20220508 (https://download.01.org/0day-ci/archive/20250104/202501042317.rG3tE7M5-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250104/202501042317.rG3tE7M5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501042317.rG3tE7M5-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/ntb/msi.c:38: warning: Function parameter or struct member 'desc_changed' not described in 'ntb_msi_init'
   drivers/ntb/msi.c:288: warning: Function parameter or struct member 'name' not described in 'ntbm_msi_request_threaded_irq'
   drivers/ntb/msi.c:288: warning: Function parameter or struct member 'msi_desc' not described in 'ntbm_msi_request_threaded_irq'
   drivers/ntb/msi.c:288: warning: Excess function parameter 'devname' description in 'ntbm_msi_request_threaded_irq'


vim +38 drivers/ntb/msi.c

    22	
    23	/**
    24	 * ntb_msi_init() - Initialize the MSI context
    25	 * @ntb:	NTB device context
    26	 *
    27	 * This function must be called before any other ntb_msi function.
    28	 * It initializes the context for MSI operations and maps
    29	 * the peer memory windows.
    30	 *
    31	 * This function reserves the last N outbound memory windows (where N
    32	 * is the number of peers).
    33	 *
    34	 * Return: Zero on success, otherwise a negative error number.
    35	 */
    36	int ntb_msi_init(struct ntb_dev *ntb,
    37			 void (*desc_changed)(void *ctx))
  > 38	{
    39		phys_addr_t mw_phys_addr;
    40		resource_size_t mw_size;
    41		size_t struct_size;
    42		int peer_widx;
    43		int peers;
    44		int ret;
    45		int i;
    46	
    47		peers = ntb_peer_port_count(ntb);
    48		if (peers <= 0)
    49			return -EINVAL;
    50	
    51		struct_size = sizeof(*ntb->msi) + sizeof(*ntb->msi->peer_mws) * peers;
    52	
    53		ntb->msi = devm_kzalloc(&ntb->dev, struct_size, GFP_KERNEL);
    54		if (!ntb->msi)
    55			return -ENOMEM;
    56	
    57		ntb->msi->desc_changed = desc_changed;
    58	
    59		for (i = 0; i < peers; i++) {
    60			peer_widx = ntb_peer_mw_count(ntb) - 1 - i;
    61	
    62			ret = ntb_peer_mw_get_addr(ntb, peer_widx, &mw_phys_addr,
    63						   &mw_size);
    64			if (ret)
    65				goto unroll;
    66	
    67			ntb->msi->peer_mws[i] = devm_ioremap(&ntb->dev, mw_phys_addr,
    68							     mw_size);
    69			if (!ntb->msi->peer_mws[i]) {
    70				ret = -EFAULT;
    71				goto unroll;
    72			}
    73		}
    74	
    75		return 0;
    76	
    77	unroll:
    78		for (i = 0; i < peers; i++)
    79			if (ntb->msi->peer_mws[i])
    80				devm_iounmap(&ntb->dev, ntb->msi->peer_mws[i]);
    81	
    82		devm_kfree(&ntb->dev, ntb->msi);
    83		ntb->msi = NULL;
    84		return ret;
    85	}
    86	EXPORT_SYMBOL(ntb_msi_init);
    87	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki