linux-kernel - Re: [PATCH 1/3] i2c: davinci: kill platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fxj2tqrjfr23cxqmtmpj74bombtfjn3qtpz5iiegvhbap7v5md@pkmrskwamatl>
Date: Sat, 4 Jan 2025 01:02:51 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Wolfram Sang <wsa@...-dreams.de>, linux-arm-kernel@...ts.infradead.org, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/3] i2c: davinci: kill platform data

Hi Bartosz,

On Thu, Jan 02, 2025 at 01:44:10PM +0100, Bartosz Golaszewski wrote:
> On Fri, Dec 27, 2024 at 12:41 AM Andi Shyti <andi.shyti@...nel.org> wrote:
> >
> > Hi Bartosz,
> >
> > ...
> >
> > >  struct davinci_i2c_dev {
> > >       struct device           *dev;
> > >       void __iomem            *base;
> > > @@ -132,13 +133,10 @@ struct davinci_i2c_dev {
> > >  #ifdef CONFIG_CPU_FREQ
> > >       struct notifier_block   freq_transition;
> > >  #endif
> > > -     struct davinci_i2c_platform_data *pdata;
> > > -};
> > > -
> > > -/* default platform data to use if not supplied in the platform_device */
> > > -static struct davinci_i2c_platform_data davinci_i2c_platform_data_default = {
> > > -     .bus_freq       = 100,
> > > -     .bus_delay      = 0,
> >
> > what happened to bus_delay?
> >
> 
> bus_delay is not set by means other than platform data and it defaults
> to 0 so it's safe to just remove it.

yes, but how is it related to this patch? Can we put it on a
different patch?

Thanks,
Andi

> > ...
> >
> > > +     /* standard bus frequency (kHz) */
> > > +     unsigned int            bus_freq;
> > > +     /* Chip has a ICPFUNC register */
> > > +     bool                    has_pfunc;
> > >  };
> >
> > > -static struct i2c_bus_recovery_info davinci_i2c_gpio_recovery_info = {
> > > -     .recover_bus = i2c_generic_scl_recovery,
> > > -     .prepare_recovery = davinci_i2c_prepare_recovery,
> > > -     .unprepare_recovery = davinci_i2c_unprepare_recovery,
> > > -};
> > > -
> >
> > what happened to the gpio_recovery_info?
> >
> 
> Similar story: it's only ever used if there's a pdata-provided
> recovery GPIO line set but nobody does it anymore.
> 
> Bartosz