linux-kernel - Re: [PATCH] mm: ensure the uniformity of arguments passed to do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3lloz-Deza8XXtO@casper.infradead.org>
Date: Sat, 4 Jan 2025 16:45:23 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Leesoo Ahn <lsahn@...eel.net>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: ensure the uniformity of arguments passed to
 do_mmap(..)

On Sat, Jan 04, 2025 at 03:39:25PM +0900, Leesoo Ahn wrote:
> Standardize the way of passing a value to @populate parameter of do_mmap(..)
> as follow:
> 
> 1. Caller must initialize the variable to 0, except it's clarified as
>    the name of the variable, 'unused'.
> 2. do_mmap(..) doesn't take care of its initialization.

Why?  This seems fragile.