linux-kernel - Re: [PATCH v2 3/3] platform/x86: acer-wmi: simplify platform profile cycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALiyAokph3JiReKsod3CZuxyVMqqmXqQ1t2rsH2wUx=hKaZm0Q@mail.gmail.com>
Date: Sat, 4 Jan 2025 23:49:52 +0530
From: Hridesh MG <hridesh699@...il.com>
To: Kurt Borja <kuurtb@...il.com>
Cc: Hans de Goede <hdegoede@...hat.com>, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	Armin Wolf <W_Armin@....de>, platform-driver-x86@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>, 
	SungHwan Jung <onenowy@...il.com>
Subject: Re: [PATCH v2 3/3] platform/x86: acer-wmi: simplify platform profile cycling

On Sat, Jan 4, 2025 at 11:23 PM Kurt Borja <kuurtb@...il.com> wrote:
>
> On Sat, Jan 04, 2025 at 08:59:22PM +0530, Hridesh MG wrote:
> > Make use of platform_profile_cycle() to simplify the logic used for
> > cycling through the different platform profiles. Also remove the
> > handling for AC power as the hardware will accept the different profiles
> > regardless of whether or not AC is plugged in.
> >
> > Link: https://lore.kernel.org/platform-driver-x86/20e3ac66-b040-49a9-ab00-0adcfdaed2ff@gmx.de/
> > Signed-off-by: Hridesh MG <hridesh699@...il.com>
> > ---
> >  drivers/platform/x86/acer-wmi.c | 87 +++++++++++------------------------------
> >  1 file changed, 23 insertions(+), 64 deletions(-)
> >
> > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > index f6c47deb4c452fc193f22c479c730aecb1e69e44..9c73f78eb302323299e03bf9dbeb2c68bb422938 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -34,6 +34,7 @@
> >  #include <linux/unaligned.h>
> >  #include <linux/bitfield.h>
> >  #include <linux/bitops.h>
> > +#include "linux/bitmap.h"
> >
> >  MODULE_AUTHOR("Carlos Corbacho");
> >  MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver");
> > @@ -1975,9 +1976,6 @@ acer_predator_v4_platform_profile_set(struct platform_profile_handler *pprof,
> >       if (err)
> >               return err;
> >
> > -     if (tp != ACER_PREDATOR_V4_THERMAL_PROFILE_TURBO)
> > -             last_non_turbo_profile = tp;
> > -
>
> I think this should be kept. If the user changes profile manually this
> may not reflect the actual last_non_turbo_profile.
I thought that the purpose of last_non_turbo_profile was for
acer_thermal_profile_change() to store the profile just before
toggling turbo so that the system can return to it later on (as
mentioned in the comments). I don't see a valid use case for this
variable outside of that specific context, which is why I decided to
remove its update during manual profile changes.

Thanks,
Hridesh MG