linux-kernel - Re: [PATCH] arm64: dts: exynos990: Rename and sort PMU nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b66b484-badb-4a99-b19f-5cab019cc5ea@gmail.com>
Date: Sun, 5 Jan 2025 14:10:37 +0200
From: Markuss Broks <markuss.broks@...il.com>
To: Igor Belwon <igor.belwon@...tallysanemainliners.org>,
 Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: exynos990: Rename and sort PMU nodes

Hi Igor,

On 1/5/25 2:03 PM, Igor Belwon wrote:
> On Sun, Jan 05, 2025 at 01:39:04PM +0200, Ivaylo Ivanov wrote:
>> On 1/5/25 13:16, Igor Belwon wrote:
>>> These nodes were sorted by name, but it's nice to have the same class of
>>> devices together. As such, drop the pmu suffix and add "pmu" as a prefix.
>>> This keeps consistency between other Exynos SoCs too.
>> Well, most SoC device trees still have it as a suffix. Perhaps it'd be better to
>> apply this change for all exynos device trees instead of waiting for other
>> people to apply it separately?
>>
>> Best regards,
>> Ivaylo
> Hi Ivaylo,
>
> The newly-merged 9810 SoC had it hand-fixed by Krzysztof while being
> merged [1], and there is a current patch to fix it on 8895 [2].
> That's all the SoCs with Mongoose cores (and the Mongoose PMU breaks
> sorting). Only 990 is missing this change.
I believe for Cortex PMUs it's also preferred to use the e.g. pmu-a53 
name instead of arm-a53-pmu. This name is at least also used on 
exynosautov9, exynosautov920, exynos7885, exynos5433 and exynos7 (list 
not conclusive). So maybe could fix it on all SoCs at once, instead of 
making individual patches for every one. This is just a suggestion 
though, your patch seems ok.
>
> [1] https://lore.kernel.org/linux-samsung-soc/d1c6d2f2-f733-4cbe-8108-c9c9aaa417cc@kernel.org/
> [2] https://lore.kernel.org/linux-samsung-soc/20241222145257.31451-1-krzysztof.kozlowski@linaro.org/
>
> Thanks and best regards,
> Igor
>

- Markuss