linux-kernel - Re: [PATCH v3] lockdown: Initialize array before use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f7db63290c5c81513721f10a65f602e@paul-moore.com>
Date: Sun, 05 Jan 2025 12:48:41 -0500
From: Paul Moore <paul@...l-moore.com>
To: Tanya Agarwal <tanyaagarwal25699@...il.com>, jmorris@...ei.org, serge@...lyn.com
Cc: kees@...nel.org, yuehaibing@...wei.com, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, matthewgarrett@...gle.com, skhan@...uxfoundation.org, anupnewsmail@...il.com, tanyaagarwal25699@...il.com
Subject: Re: [PATCH v3] lockdown: Initialize array before use

On Jan  5, 2025 Tanya Agarwal <tanyaagarwal25699@...il.com> wrote:
> 
> The static code analysis tool "Coverity Scan" pointed the following
> details out for further development considerations:
> CID 1486102: Uninitialized scalar variable (UNINIT)
> uninit_use_in_call: Using uninitialized value *temp when calling
> strlen.
> 
> Conclusion:
> Initialize array before use in lockdown_read() to satisfy the static
> analyzer.
> 
> Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@...il.com>

I removed the 'Fixes:' tag as the code isn't actually broken as we
discussed in previous iterations of this patch.  I also edited the
subject line and commit description a bit, but otherwise this is
fine.  Merged into lsm/dev.

--
paul-moore.com