linux-kernel - Re: [RESEND PATCH] MAINTAINERS: Fix list entries with display names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd3f97782bb8b2a44023cf1f4dd7dedb1de0b3ae.camel@perches.com>
Date: Sun, 05 Jan 2025 09:19:27 -0800
From: Joe Perches <joe@...ches.com>
To: Rob Herring <robh@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] MAINTAINERS: Fix list entries with display names

On Fri, 2025-01-03 at 08:08 -0600, Rob Herring wrote:
> On Thu, Jan 2, 2025 at 5:47 PM Andrew Morton <[akpm@...ux-foundation.org](mailto:akpm@...ux-foundation.org)> wrote:
> > On Tue, 31 Dec 2024 09:54:14 -0600 "Rob Herring (Arm)" <[robh@...nel.org](mailto:robh@...nel.org)> wrote:
> > > get_maintainers.pl doesn't expect list entries to have a display name.
> > > Entries with a display name are omitted and print just the description:
> > > 
> > >  (open list:PIN CONTROLLER - FREESCALE)
> > > 
> > > These cases are pretty much aliases to a few people, not lists which
> > > are archived and can be subscribed to. Change these cases to be reviewers
> > > instead.
> > 
> > Feels a bit wrong.  Are you sure that *all* of the below "lists" are
> > not really lists?  If so then OK I suppose.  Or perhaps we should have
> > a new MAINTAINERS tag to cover this situation.
> They certainly don't look like anything anyone outside those
> organizations can subscribe to or would have public archives. Whether
> they are lists or aliases internally doesn't matter to us.
> > And shouldn't get_maintainer be made to be more friendly in its
> > handling of these entries?  Omitting the email address seems kinda dumb.
> > 
[]
> That's certainly an alternate or additional fix. I was hoping Joe
> would know where to fix that rather than me trying to wade thru perl.
> :)

Maybe something like this:
---
 scripts/get_maintainer.pl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index ee1aed7e090ca..c5486827c81b5 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1332,6 +1332,7 @@ sub add_categories {
 	    my $ptype = $1;
 	    my $pvalue = $2;
 	    if ($ptype eq "L") {
+		my $list_name = "";
 		my $list_address = $pvalue;
 		my $list_additional = "";
 		my $list_role = get_list_role($i);
@@ -1339,10 +1340,16 @@ sub add_categories {
 		if ($list_role ne "") {
 		    $list_role = ":" . $list_role;
 		}
-		if ($list_address =~ m/([^\s]+)\s+(.*)$/) {
+		if ($list_address =~ m/^([^\<]+)\<(\S+@\S+)\>\s*(.*)$/) {
+		    $list_name = $1;
+		    $list_address = $2;
+		    $list_additional = $3;
+		    $list_name =~ s/^\s+|\s+$//g; #trim
+		} elsif ($list_address =~ m/([^\s]+)\s+(.*)$/) {
 		    $list_address = $1;
 		    $list_additional = $2;
 		}
+
 		if ($list_additional =~ m/subscribers-only/) {
 		    if ($email_subscriber_list) {
 			if (!$hash_list_to{lc($list_address)}) {