linux-kernel - Re: [PATCH] PCI: fix reference leak in pci_register_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c80c06f6-d283-4687-bf32-9b6be19c8257@web.de>
Date: Sun, 5 Jan 2025 21:26:40 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, linux-pci@...r.kernel.org,
 Arnd Bergmann <arnd@...db.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Thierry Reding <treding@...dia.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] PCI: fix reference leak in pci_register_host_bridge()

> Once device_register() failed, we should call put_device() to
> decrement reference count for cleanup. Or it could cause memory leak.
>
> device_register() includes device_add(). As comment of device_add()
…

I doubt that the information from the second description paragraph is helpful
for this issue.


> Found by code review.

Would you become interested to check how many similar control flows
can still be detected by the means of automated advanced source code analyses?

Regards,
Markus