linux-kernel - Re: [PATCH 2/2] drm/i2c: move TDA drivers under drivers/gpu/drm/bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250105232018.GB21164@pendragon.ideasonboard.com>
Date: Mon, 6 Jan 2025 01:20:18 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Liviu Dudau <liviu.dudau@....com>,
	Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>, Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	Hans Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH 2/2] drm/i2c: move TDA drivers under
 drivers/gpu/drm/bridge

(CC'ing Hans Verkuil)

On Mon, Jan 06, 2025 at 12:52:55AM +0200, Dmitry Baryshkov wrote:
> On Sun, Dec 15, 2024 at 02:38:05PM +0200, Laurent Pinchart wrote:
> > Hi Dmitry,
> > 
> > Thank you for the patch.
> > 
> > On Sun, Dec 15, 2024 at 01:09:08PM +0200, Dmitry Baryshkov wrote:
> > > TDA998x is the HDMI bridge driver, incorporating drm_connector and
> > > optional drm_encoder (created via the component bind API by the TICLDC
> > > and HDLCD drivers). Thus it should be residing together with the other
> > > DRM bridge drivers under drivers/gpu/drm/bridge/.
> > > 
> > > TDA9950 is an I2C-CEC translator, being present on-die on the TDA9989
> > > and TDA19989 chips, so it is being instantiated by the TDA998x driver.
> > > Move it together with the TDA998x under bridge drivers subdir.
> > > 
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > > ---
> > >  MAINTAINERS                                       |  2 +-
> > >  drivers/gpu/drm/arm/Kconfig                       |  1 +
> > >  drivers/gpu/drm/bridge/Kconfig                    |  2 ++
> > >  drivers/gpu/drm/bridge/Makefile                   |  1 +
> > >  drivers/gpu/drm/bridge/tda/Kconfig                | 13 +++++++++++++
> > >  drivers/gpu/drm/bridge/tda/Makefile               |  4 ++++
> > >  drivers/gpu/drm/{i2c => bridge/tda}/tda9950.c     |  0
> > >  drivers/gpu/drm/{i2c => bridge/tda}/tda998x_drv.c |  0
> > 
> > I probably wouldn't have created a tda/ subdirectory in bridge/, but I
> > don't mind much either way.
> 
> A possibly better option is to move tsa9950.c to drivers/media/cec/i2c/
> next to ch7332 CEC driver. WDYT?

I think that's a question for Hans. I don't mind much either way.

> If I don't get any response from Russell within the next few days, I
> think I'll post v2 performing these two moves: tda9950 to
> drivers/media/cec/i2c and tda998x to drivers/gpu/drm/bridge without the
> tda/ subdir.
> 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

-- 
Regards,

Laurent Pinchart