linux-kernel - drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'nvram_start' not described in 'bcm47xx_nvram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202501050807.zSLXTjFm-lkp@intel.com>
Date: Sun, 5 Jan 2025 08:59:22 +0800
From: kernel test robot <lkp@...el.com>
To: Rafał Miłecki <rafal@...ecki.pl>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function
 parameter or struct member 'nvram_start' not described in
 'bcm47xx_nvram_copy'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ab75170520d4964f3acf8bb1f91d34cbc650688e
commit: 298923cf999cecd2ef06df126f85a3d68da8c4d8 firmware: bcm47xx_nvram: extract code copying NVRAM
date:   3 years, 10 months ago
config: parisc-randconfig-c44-20220907 (https://download.01.org/0day-ci/archive/20250105/202501050807.zSLXTjFm-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250105/202501050807.zSLXTjFm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501050807.zSLXTjFm-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/firmware/broadcom/bcm47xx_nvram.c:41: warning: Function parameter or struct member 'nvram' not described in 'bcm47xx_nvram_is_valid'
>> drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'nvram_start' not described in 'bcm47xx_nvram_copy'
>> drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'res_size' not described in 'bcm47xx_nvram_copy'
   drivers/firmware/broadcom/bcm47xx_nvram.c:85: warning: Function parameter or struct member 'flash_start' not described in 'bcm47xx_nvram_find_and_copy'
   drivers/firmware/broadcom/bcm47xx_nvram.c:85: warning: Function parameter or struct member 'res_size' not described in 'bcm47xx_nvram_find_and_copy'


vim +61 drivers/firmware/broadcom/bcm47xx_nvram.c

    36	
    37	/**
    38	 * bcm47xx_nvram_is_valid - check for a valid NVRAM at specified memory
    39	 */
    40	static bool bcm47xx_nvram_is_valid(void __iomem *nvram)
  > 41	{
    42		return ((struct nvram_header *)nvram)->magic == NVRAM_MAGIC;
    43	}
    44	
    45	static u32 find_nvram_size(void __iomem *end)
    46	{
    47		int i;
    48	
    49		for (i = 0; i < ARRAY_SIZE(nvram_sizes); i++) {
    50			if (bcm47xx_nvram_is_valid(end - nvram_sizes[i]))
    51				return nvram_sizes[i];
    52		}
    53	
    54		return 0;
    55	}
    56	
    57	/**
    58	 * bcm47xx_nvram_copy - copy NVRAM to internal buffer
    59	 */
    60	static void bcm47xx_nvram_copy(void __iomem *nvram_start, size_t res_size)
  > 61	{
    62		struct nvram_header __iomem *header = nvram_start;
    63		size_t copy_size;
    64	
    65		copy_size = header->len;
    66		if (copy_size > res_size) {
    67			pr_err("The nvram size according to the header seems to be bigger than the partition on flash\n");
    68			copy_size = res_size;
    69		}
    70		if (copy_size >= NVRAM_SPACE) {
    71			pr_err("nvram on flash (%zu bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
    72			       copy_size, NVRAM_SPACE - 1);
    73			copy_size = NVRAM_SPACE - 1;
    74		}
    75	
    76		__ioread32_copy(nvram_buf, nvram_start, DIV_ROUND_UP(copy_size, 4));
    77		nvram_buf[NVRAM_SPACE - 1] = '\0';
    78		nvram_len = copy_size;
    79	}
    80	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki