linux-kernel - Re: [RFC PATCH] get_maintainer: decouple subsystem status from maintainer role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7224dba8-97fd-458f-a262-50ce9b040f3b@leemhuis.info>
Date: Mon, 6 Jan 2025 19:21:25 +0100
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Joe Perches <joe@...ches.com>, workflows@...r.kernel.org,
 linux-kernel@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Kees Cook <kees@...nel.org>
Subject: Re: [RFC PATCH] get_maintainer: decouple subsystem status from
 maintainer role

Lo! From the "better reply late than never" department:

Thx for picking this up again, much appreciated!

On 18.12.24 06:48, Kees Cook wrote:
> On Fri, Dec 13, 2024 at 12:29:22PM +0100, Vlastimil Babka wrote:
>> The script currently uses the subystem's status (S: field) to change how
>> maintainers are reported. One prominent example is when the status is
>> Supported, the maintainers are reported as "(supporter:SUBSYSTEM)".
>>
>> This is misleading, as the Supported status defined as "Someone is
>> actually paid to look after this." may not in fact apply to everyone
>> listed as a maintainer, but only to some of them.
>>
>> It has also been confusing people to what "supporter" means and has
>> required updates to the documentation [1].
>>
>> Thus stop applying the subsystem status to change "maintainer:" to
>> anything else, as maintainers are maintainers. Instead, if the subsystem
>> status is not the most common one (Maintained), indicate it as part of
>> the subsystem name. So for example, instead of "(supporter:SUBSYSTEM)"
>> report "(maintainer:SUBSYSTEM [supported])".

As Kees mentioned: "funded" might be better. Or is there even a better
word for this? "backed"? "subsidized"?

When I read this for the first time I thought "it would be better to
keep the two aspects closer together, e.g.
"(maintainer[supported]:SUBSYSTEM)". But then I read... (continue below)

>> [1] https://lore.kernel.org/all/20221006162413.858527-1-bryan.odonoghue@linaro.org/
> [...]
>> ---
>> I have been confused myself in the past seeing "supporter" and have seen
>> somebody recently wondering what it means as well.
>>
>> I have read the threads from 2022 that in the end resulted in adjusting
>> documentation only [1]. I very much agree with Ted's points about taking
>> the subsystem status and applying it to all maintainers being wrong [2].
>>
>> The attempt to modify get_maintainer output was retracted after Joe
>> objected that the status becomes not reported at all [3]. This RFC
>> attempts to address that by reporting the status (unless it's the most
>> common one) as part of the subsystem.
>>
>> The patch is not perfect, as with this approach, the logical thing would
>> be to do the same also for reviewers and mailing lists. In fact,
>> subsystems with a status of Orphan typically only have some catch-all
>> mailing list and no maintainers, so the "(orphan minder:SUBSYSTEM)"
>> would never be currently reported by checkpatch. It would be thus
>> logical to report the status in the same way for lists (and reviewers).
>>
>> But I didn't attempt a full implementation as I'm not fluent in Perl and
>> would like to see if we can get a consensus first. If we do, I don't
>> insist in this particular "SUBSYSTEM [status]" syntax nor on
>> implementing the full solution myself - I would be happy if somebody
>> else did. My main point is that maintainer is a maintainer and the
>> subsystem status should be indicated for the subsystem, not for the
>> maintainer.
>>
>> [1] https://lore.kernel.org/all/20221006162413.858527-1-bryan.odonoghue@linaro.org/
>> [2] https://lore.kernel.org/all/Yzen4X1Na0MKXHs9@mit.edu/
>> [3] https://lore.kernel.org/all/30776fe75061951777da8fa6618ae89bea7a8ce4.camel@perches.com/
> 
> Do we want to change "Supported" to "Funded" to help clear up the
> meaning? (But yes, I agree, that the subsystem status should be applied
> to the subsystem, not the individual contacts.)

...this and thought: well, the current format of MAINTAINERS applies the
status to all maintainers, even is some of them are funded while others
are not. Changing this would likely require bigger changes. But I'm
unsure if that is really worth it. Guess not, because it's likely a rare
case. So I guess the format you chose is the best for now.

Thx again for doing this, I like it.

Ciao, Thorsten