linux-kernel - Re: wakeup_pipe_readers/writers() && pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250106183646.GG7233@redhat.com>
Date: Mon, 6 Jan 2025 19:36:47 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Manfred Spraul <manfred@...orfullife.com>,
	Christian Brauner <brauner@...nel.org>,
	David Howells <dhowells@...hat.com>,
	WangYuli <wangyuli@...ontech.com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: wakeup_pipe_readers/writers() && pipe_poll()

On 01/06, Linus Torvalds wrote:
>
> On Mon, 6 Jan 2025 at 08:31, Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > To be honest, I don't understand the wait_address check in poll_wait(),
> > it seems that wait_address is never NULL.
>
> Oh, it seems to be historical.

Yeah, please see my previous email.

I think it must die, but needs another one-liner.

> > That is what I tried to propose. Will you agree with this change?
> > We can even use smp_store_mb(), say
>
> I think it's clearer to just use smp_mb().

OK, agreed, I'll send the trivial patch once I write the changelog.

Oleg.