linux-kernel - Re: [PATCH v15 01/13] x86/sev: Carve out and export SNP guest messaging init routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bc77e37-56e4-45be-9038-6ed1bd21c33f@amd.com>
Date: Mon, 6 Jan 2025 09:44:41 +0530
From: "Nikunj A. Dadhania" <nikunj@....com>
To: Francesco Lavra <francescolavra.fl@...il.com>
Cc: bp@...en8.de, dave.hansen@...ux.intel.com, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, mingo@...hat.com, pbonzini@...hat.com,
 pgonda@...gle.com, seanjc@...gle.com, tglx@...utronix.de,
 thomas.lendacky@....com, x86@...nel.org
Subject: Re: [PATCH v15 01/13] x86/sev: Carve out and export SNP guest
 messaging init routines

On 1/5/2025 12:36 AM, Francesco Lavra wrote:
> On 2024-12-03 at 9:00, Nikunj A Dadhania wrote:
> 
>> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
>> index c5b0148b8c0a..3cc741eefd06 100644
>> --- a/arch/x86/coco/sev/core.c
>> +++ b/arch/x86/coco/sev/core.c
> ...
>> +void snp_msg_free(struct snp_msg_desc *mdesc)
>> +{
>> +	if (!mdesc)
>> +		return;
>> +
>> +	mdesc->vmpck = NULL;
>> +	mdesc->os_area_msg_seqno = NULL;
>> +	kfree(mdesc->ctx);
>> +
>> +	free_shared_pages(mdesc->response, sizeof(struct
>> snp_guest_msg));
>> +	free_shared_pages(mdesc->request, sizeof(struct
>> snp_guest_msg));
>> +	iounmap((__force void __iomem *)mdesc->secrets);
>> +	kfree(mdesc);
> 
> This is leaking mdesc->certs_data.

Ack, will fix in the next version.

Regards
Nikunj