linux-kernel - Re: [PATCH 3/3] hwmon/adt7470: create 'temp_fan_norm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <894c78d4-35e9-487a-92c3-9a7eb808f040@roeck-us.net>
Date: Mon, 6 Jan 2025 11:10:18 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Adrian DC <radian.dc@...il.com>, Jean Delvare <jdelvare@...e.com>,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] hwmon/adt7470: create 'temp_fan_norm_alarm' attribute
 for 'NORM' alarm

On 1/5/25 11:55, Adrian DC wrote:
> Default: 0 in all normal use cases
> Test: Raises to 1 if all FANs are in automatic mode and below threshold

As with the other patches, this is not an acceptable patch description.

On top of that, it introduces a non-standard attribute without documenting
it nor providing a rationale explaining the need for it. Also, this is not
an alarm. The bit says "everything is normal". I fail to see the value of
such an attribute, much less as an "alarm" attribute.

Guenter