linux-kernel - Re: [PATCH] binder: fix kernel-doc warning of 'file' member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHRSSEydJ_VHc3kaPzmi_tfnUbAPTXXNOpsfq2ZajDY6CnOpgQ@mail.gmail.com>
Date: Mon, 6 Jan 2025 12:01:33 -0800
From: Todd Kjos <tkjos@...gle.com>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, 
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>, 
	Joel Fernandes <joel@...lfernandes.org>, Christian Brauner <brauner@...nel.org>, 
	Suren Baghdasaryan <surenb@...gle.com>, linux-kernel@...r.kernel.org, kernel-team@...roid.com, 
	oe-kbuild-all@...ts.linux.dev, paulmck@...nel.org, uladzislau.rezki@...y.com, 
	urezki@...il.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] binder: fix kernel-doc warning of 'file' member

On Mon, Jan 6, 2025 at 11:26 AM Carlos Llamas <cmllamas@...gle.com> wrote:
>
> The 'struct file' member in 'binder_task_work_cb' definition was renamed
> to 'file' between patch versions but its kernel-doc reference kept the
> old name 'fd'. Update the naming to fix the W=1 build warning.
>
> Cc: Todd Kjos <tkjos@...gle.com>
> Fixes: 80cd795630d6 ("binder: fix use-after-free due to ksys_close() during fdget()")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501031535.erbln3A2-lkp@intel.com/
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

Acked-by: Todd Kjos <tkjos@...gle.com>

> ---
>  drivers/android/binder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index ef353ca13c35..f790356750e9 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -1971,7 +1971,7 @@ static bool binder_validate_fixup(struct binder_proc *proc,
>   * struct binder_task_work_cb - for deferred close
>   *
>   * @twork:                callback_head for task work
> - * @fd:                   fd to close
> + * @file:                 file to close
>   *
>   * Structure to pass task work to be handled after
>   * returning from binder_ioctl() via task_work_add().
> --
> 2.47.1.613.gc27f4b7a9f-goog
>