| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e2e314ad-82a2-4aed-adc5-c1fa45762972@nvidia.com>
Date: Mon, 6 Jan 2025 12:45:11 -0800
From: Tushar Dave <tdave@...dia.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: corbet@....net, bhelgaas@...gle.com, paulmck@...nel.org,
akpm@...ux-foundation.org, thuth@...hat.com, rostedt@...dmis.org,
xiongwei.song@...driver.com, vidyas@...dia.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, vsethi@...dia.com,
jgg@...dia.com, sdonthineni@...dia.com
Subject: Re: [PATCH 1/1] PCI: Fix Extend ACS configurability
On 1/2/25 15:26, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2024 at 12:29:42PM -0800, Tushar Dave wrote:
>> Commit 47c8846a49ba ("PCI: Extend ACS configurability") introduced a
>> bug that fails to configure ACS ctrl for multiple PCI devices. It
>> affects both 'config_acs' and 'disable_acs_redir'.
>>
>> For example, using 'config_acs' to configure ACS ctrl for multiple BDFs
>> fails:
>>
>> [ 0.000000] Kernel command line: pci=config_acs=1111011@...0:02:00.0;101xxxx@...9:00:00.0 "dyndbg=file drivers/pci/pci.c +p" earlycon
>> [ 12.349875] PCI: Can't parse ACS command line parameter
>> [ 19.629314] pci 0020:02:00.0: ACS mask = 0x007f
>> [ 19.629315] pci 0020:02:00.0: ACS flags = 0x007b
>> [ 19.629316] pci 0020:02:00.0: Configured ACS to 0x007b
>
> Drop timestamps (unless they contribute to understanding the
> problem) and indent the quoted material by a couple spaces.
Thanks Bjorn. will do in v2.
-Tushar
Powered by blists - more mailing lists