linux-kernel - Re: [PATCH net-next v1] net: stmmac: Unexport stmmac_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f0b5132-9695-4da6-ae87-1e0757253c07@lunn.ch>
Date: Mon, 6 Jan 2025 22:05:44 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Furong Xu <0x1207@...il.com>
Cc: netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, xfr@...look.com
Subject: Re: [PATCH net-next v1] net: stmmac: Unexport stmmac_rx_offset()
 from stmmac.h

> +static inline unsigned int stmmac_rx_offset(struct stmmac_priv *priv)
> +{
> +	if (stmmac_xdp_is_enabled(priv))
> +		return XDP_PACKET_HEADROOM;
> +
> +	return 0;
> +}

Please drop the inline keyword. You don't need it in a .c file, it is
better to let the compiler to decide.


    Andrew

---
pw-bot: cr