linux-kernel - Re: dm: Allow the use of escaped characters in str_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3xKkYyNCQaRqzjZ@hammerspace.com>
Date: Mon, 6 Jan 2025 16:27:07 -0500
From: Mike Snitzer <snitzer@...merspace.com>
To: Mikulas Patocka <mpatocka@...hat.com>
Cc: Mohammed Anees <pvmohammedanees2003@...il.com>, agk@...hat.com,
	dm-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
	zkabelac@...hat.com
Subject: Re: dm: Allow the use of escaped characters in str_field_delimit()

On Fri, Jan 03, 2025 at 05:21:13PM +0100, Mikulas Patocka wrote:
> 
> 
> On Sun, 15 Dec 2024, Mohammed Anees wrote:
> 
> > > It would seem Mohammed cared enough to write the patch, but not reply
> > > to you with further clarification on why it needed...
> > 
> > I thought I had already replied to the concern, but it seems 
> > the message didn´t get sent, apologies for that oversight!
> > College academics kept me tied up, and I lost track of this,
> > apologies once again.
> > 
> > > BUT, in this instance it follows that: if lvm2 is allowing weird names
> > > which require escacped characters _and_ dm-init is used then dm-init
> > > needs to support handling them (dm-init is all about _not_ using
> > > normal initramfs with lvm2 in all its glory).
> > 
> > I completely agree with your point and am more than happy to 
> > provide further details or make any additional updates to 
> > the patch if needed, please let me know if anything else if needed. 
> > Thank you for your time.
> > 
> > Regards
> > Mohammed Anees
> 
> Hi
> 
> I don't want to bloat the code with the logic that no one uses. I would 
> only accept the patch if there were some real scenario where you need to 
> use escaped characters in device names or table parameters.

Please read my reply in this thread (which you quoted above).  The
real scenario was already answered.

Either:

1) remove dm-init entirely

or

2) fix it so that it works with naming that requires escaped
   characters 
or

3) say: "sorry, dm-init doesn't support escaped characters."