linux-kernel - Re: [PATCH] perf test trace_btf_general: Fix shellcheck warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3xPY-z0uXQNy6a3@google.com>
Date: Mon, 6 Jan 2025 13:47:15 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: James Clark <james.clark@...aro.org>
Cc: linux-perf-users@...r.kernel.org, acme@...nel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	Howard Chu <howardchu95@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf test trace_btf_general: Fix shellcheck warning

On Mon, Jan 06, 2025 at 04:42:58PM +0000, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
> 
>   tests/shell/trace_btf_general.sh line 8:
>   . "$(dirname $0)"/lib/probe.sh
>   ^--------------------------^ SC1090: Can't follow non-constant source.
>   Use a directive to specify location.
> 
> Fixes: 0255338d6975 ("perf trace: Add tests for BTF general augmentation")
> Signed-off-by: James Clark <james.clark@...aro.org>
> ---

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

>  tools/perf/tests/shell/trace_btf_general.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> index 005c93e6c770..e9ee727f3433 100755
> --- a/tools/perf/tests/shell/trace_btf_general.sh
> +++ b/tools/perf/tests/shell/trace_btf_general.sh
> @@ -5,6 +5,7 @@
>  err=0
>  set -e
>  
> +# shellcheck source=lib/probe.sh
>  . "$(dirname $0)"/lib/probe.sh
>  
>  file1=$(mktemp /tmp/file1_XXXX)
> -- 
> 2.34.1
>