linux-kernel - Re: [PATCH v2] wifi: wlcore: fix unbalanced pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b198db94-1857-4c2a-94d9-69dc13d7c67d@ti.com>
Date: Mon, 6 Jan 2025 08:22:14 +0200
From: "Nemanov, Michael" <michael.nemanov@...com>
To: <akemnade@...nel.org>, <kvalo@...nel.org>, <rmk+kernel@...linux.org.uk>,
        <johannes.berg@...el.com>, <miriam.rachel.korenblit@...el.com>,
        <leitao@...ian.org>, <andreas@...nade.info>,
        <emmanuel.grumbach@...el.com>, <tony@...mide.com>,
        <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] wifi: wlcore: fix unbalanced pm_runtime calls

On 1/4/2025 9:55 PM, akemnade@...nel.org wrote:
> From: Andreas Kemnade <andreas@...nade.info>
> 
> If firmware boot failes, runtime pm is put too often:
> [12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
> [12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
> Fix that by redirecting all error gotos before runtime_get so that runtime is
> not put.
> 
> Fixes: c40aad28a3cf ("wlcore: Make sure firmware is initialized in wl1271_op_add_interface()")
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>

Reviewed-by: Michael Nemanov <michael.nemanov@...com>

Best regards,
Michael.