[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ddzqybi2umjsstg7olmtjlrtfbqxnpcrcfflly7snfzcez6r7@yrkxp3sclfad>
Date: Mon, 6 Jan 2025 08:02:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>, Sam Protsenko <semen.protsenko@...aro.org>,
Peter Griffin <peter.griffin@...aro.org>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] soc: samsung: usi: implement support for USIv1
and exynos8895
On Sun, Jan 05, 2025 at 06:03:45PM +0200, Ivaylo Ivanov wrote:
> @@ -169,9 +207,12 @@ static int exynos_usi_configure(struct exynos_usi *usi)
> return ret;
>
> if (usi->data->ver == USI_VER2)
> - return exynos_usi_enable(usi);
> + ret = exynos_usi_enable(usi);
> + else
> + ret = clk_bulk_prepare_enable(usi->data->num_clks,
> + usi->clks);
You need now exynos_usi_remove() callback and also error path after
populate at end of probe.
Best regards,
Krzysztof
Powered by blists - more mailing lists