linux-kernel - Re: [PATCH] staging: greybus: Remove Module from list before freeing in gb_audio_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbdf3497-4359-4b63-b718-f53bf9ad7fc6@stanley.mountain>
Date: Mon, 6 Jan 2025 12:51:04 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Atharva Tiwari <evepolonium@...il.com>
Cc: gregkh@...uxfoundation.org, elder@...nel.org,
	greybus-dev@...ts.linaro.org, johan@...nel.org,
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
	mgreer@...malcreek.com, vaibhav.sr@...il.com
Subject: Re: [PATCH] staging: greybus: Remove Module from list before freeing
 in gb_audio_module_release

On Tue, Dec 24, 2024 at 10:49:17AM +0530, Atharva Tiwari wrote:
> Yes I have tested the patch with greybus drivers enabled on Debian 12.It works as expected, and i did not get any errors or warning during the compilation
> 
> Please let me know if further changes are required.
> 

You're trying to ensure that the list is initialized but instead of testing
for that, the correct way is to initialize it earlier in the process.

regards,
dan carpenter