linux-kernel - Re: [PATCH v2 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12636552-b644-429b-8be0-44334fae6130@kernel.org>
Date: Mon, 6 Jan 2025 13:29:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pengyu Luo <mitltlatltl@...il.com>
Cc: andersson@...nel.org, bryan.odonoghue@...aro.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, dmitry.baryshkov@...aro.org,
 gregkh@...uxfoundation.org, hdegoede@...hat.com,
 heikki.krogerus@...ux.intel.com, ilpo.jarvinen@...ux.intel.com,
 jdelvare@...e.com, konradybcio@...nel.org, krzk+dt@...nel.org,
 linux-arm-msm@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-usb@...r.kernel.org, linux@...ck-us.net,
 platform-driver-x86@...r.kernel.org, robh@...nel.org, sre@...nel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

On 06/01/2025 09:06, Pengyu Luo wrote:
>>> +      - const: huawei,gaokun-ec
>>
>> There is no support for gaokun2 here, so I assume you checked and you
>> know these are compatible. What's more, you claim there is a generic
>> piece of hardware called gaokun-ec and everything in this family will be
>> compatible with it. Well, that's my standard disclaimer and disapproval
>> of using generic compatibles.
>>
>> So in general what you want here is *only one* compatible called
>> huawei,gaokun3-ec
>>
> 
> I agree with you. If there is a generic rule to follow, I am not familiar
> with this. I have seen some bindings, using like this, so I followed it
> recently.

Generic rule is: wildcards and family names are not allowed. Now what
"generic" means, is different for different devices. If unsure, always
use only device-specific compatibles.



Best regards,
Krzysztof