linux-kernel - Re: [PATCH v2] PCI: rcar-ep: Fix the issue of the name parameter when calling devm_request_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8ve-kJoeRgS=kmzBbO_qX2nZ60WH0syMb7MEc9pHp9+9w@mail.gmail.com>
Date: Mon, 6 Jan 2025 13:17:26 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: kingdix10@...com
Cc: s.shtylyov@....ru, marek.vasut+renesas@...il.com, 
	yoshihiro.shimoda.uh@...esas.com, lpieralisi@...nel.org, kw@...ux.com, 
	manivannan.sadhasivam@...aro.org, robh@...nel.org, bhelgaas@...gle.com, 
	linux-pci@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: rcar-ep: Fix the issue of the name parameter when
 calling devm_request_mem_region

On Sun, Jan 5, 2025 at 6:03 AM <kingdix10@...com> wrote:
>
> From: King Dix <kingdix10@...com>
>
> When using devm_request_mem_region to request a resource, if the passed
> variable is a stack string variable, it will lead to an oops issue when
> eecuting the command cat /proc/iomem.
>
s/eecuting/executing

> Fix this by replacing outbound_name with the name of the previously
> requested resource.
>
Fixes: 2a6d0d63d999 ("PCI: rcar: Add endpoint mode support")
> Signed-off-by: King Dix <kingdix10@...com>
> ---
> Changes in v2:
>   - Fix the code indentation issue.
> ---
>  drivers/pci/controller/pcie-rcar-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
With the above fixed,

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index 047e2cef5afc..c5e0d025bc43 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -107,7 +107,7 @@ static int rcar_pcie_parse_outbound_ranges(struct rcar_pcie_endpoint *ep,
>                 }
>                 if (!devm_request_mem_region(&pdev->dev, res->start,
>                                              resource_size(res),
> -                                            outbound_name)) {
> +                                            res->name)) {
>                         dev_err(pcie->dev, "Cannot request memory region %s.\n",
>                                 outbound_name);
>                         return -EIO;
> --
> 2.43.0
>
>