linux-kernel - Re: [PATCH] usb: typec: fix pm usage counter imbalance in ucsi_ccg_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d1f15a1-1905-42e4-989c-f6aab7acad9f@stanley.mountain>
Date: Mon, 6 Jan 2025 17:08:09 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: GONG Ruiqi <gongruiqi1@...wei.com>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: fix pm usage counter imbalance in
 ucsi_ccg_sync_control()

On Mon, Dec 30, 2024 at 05:35:23PM +0800, GONG Ruiqi wrote:
> The error handling for the case `con_index == 0` should involve dropping
> the pm usage counter, as ucsi_ccg_sync_control() gets it at the
> beginning. Fix it.
> 
> Fixes: e56aac6e5a25 ("usb: typec: fix potential array underflow in ucsi_ccg_sync_control()")
> Signed-off-by: GONG Ruiqi <gongruiqi1@...wei.com>

Ugh.  My bad.  Sorry.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter