linux-kernel - Re: [PATCH bpf-next] bpf/tests: Add 32 bits only mong conditional jump tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76bc081f-2b2d-4b8b-9683-65ad9af8205d@iogearbox.net>
Date: Mon, 6 Jan 2025 16:12:08 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
 Johan Almbladh <johan.almbladh@...finetworks.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>
Cc: linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf/tests: Add 32 bits only mong conditional
 jump tests

On 1/6/25 10:15 AM, Christophe Leroy wrote:
> Commit f1517eb790f9 ("bpf/tests: Expand branch conversion JIT test")
> introduced "Long conditional jump tests" but due to those tests making
> use of 64 bits DIV and MOD, they don't get jited on powerpc/32,
> leading to the Long conditional jump test being skiped for unrelated
> reason.
> 
> Add 4 new tests that are restricted to 32 bits ALU so that the jump
> tests can also be performed on platforms that do no support 64 bits
> operations.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

lgtm, fixed $subj s/mong/long/ while applying, thanks!