Message-ID: <ed1af8ef-e2a8-4457-9f27-d5e2315ade74@amd.com>
Date: Mon, 6 Jan 2025 10:18:55 -0500
From: Harry Wentland <harry.wentland@....com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Maxime Ripard <mripard@...nel.org>
Cc: Jani Nikula <jani.nikula@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Tvrtko Ursulin <tursulin@...ulin.net>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, Karol Herbst <kherbst@...hat.com>,
 Lyude Paul <lyude@...hat.com>, Danilo Krummrich <dakr@...hat.com>,
 Leo Li <sunpeng.li@....com>, Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Xinhui Pan <Xinhui.Pan@....com>, Alain Volmat <alain.volmat@...s.st.com>,
 Raphael Gallais-Pou <rgallaispou@...il.com>,
 Liviu Dudau <liviu.dudau@....com>, Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Peter Senna Tschudin <peter.senna@...il.com>, Ian Ray <ian.ray@...com>,
 Martyn Welch <martyn.welch@...labora.co.uk>, Inki Dae
 <inki.dae@...sung.com>, Seung-Woo Kim <sw0312.kim@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar
 <alim.akhtar@...sung.com>, Stefan Agner <stefan@...er.ch>,
 Alison Wang <alison.wang@....com>,
 Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Rob Clark <robdclark@...il.com>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean Paul <sean@...rly.run>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Dave Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>,
 Sandy Huang <hjc@...k-chips.com>, Heiko Stübner
 <heiko@...ech.de>, Andy Yan <andy.yan@...k-chips.com>,
 Chen-Yu Tsai <wens@...e.org>, Samuel Holland <samuel@...lland.org>,
 Thierry Reding <thierry.reding@...il.com>,
 Mikko Perttunen <mperttunen@...dia.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maíra Canal <mcanal@...lia.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu
 <olvaffe@...il.com>, Zack Rusin <zack.rusin@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, intel-gfx@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, nouveau@...ts.freedesktop.org,
 amd-gfx@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
 virtualization@...ts.linux.dev, spice-devel@...ts.freedesktop.org,
 linux-rockchip@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-tegra@...r.kernel.org,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept
 const mode pointer



On 2025-01-06 04:45, Dmitry Baryshkov wrote:
> On Mon, 6 Jan 2025 at 10:55, Maxime Ripard <mripard@...nel.org> wrote:
>>
>> On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote:
>>> On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote:
>>>> While working on the generic mode_valid() implementation for the HDMI
>>>> Connector framework I noticed that unlike other DRM objects
>>>> drm_connector accepts non-const pointer to struct drm_display_mode,
>>>> while obviously mode_valid() isn't expected to modify the argument.
>>>>
>>>> Mass-change the DRM framework code to pass const argument to that
>>>> callback.
>>>>
>>>> The series has been compile-tested with defconfig for x86-64, arm and
>>>> arm64.
>>>>
>>>> Note: yes, I understand that this change might be hard to review and
>>>> merge. The only viable option that I foresee is to add new callback,
>>>> having the const argument and migrate drivers into using it one by one.
>>>
>>> Colleagues, I'd like to graciously ping regarding this series. Should it
>>> be merged as is (possibly requiring more R-B's)? Or should I rework it
>>> adding something like .mode_valid_new() callback which takes const
>>> argument?
>>
>> I think your patch is fine, and you can add my
>>
>> Reviewed-by: Maxime Ripard <mripard@...nel.org>
>>
>> We seem to lack an Acked-by for amdgpu though?
> 
> Yes. I think the AMD is the only one missing
> 
> 

For the amdgpu patch:
Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

Powered by blists - more mailing lists