linux-kernel - Re: [PATCH 3/7] ext4: Don't set EXT4_STATE_MAY_INLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7rqsgaocwcorxqe4rghhgpwy4nmmbn6r2jjmposxuqk5i7g237@r2gbucnrlep6>
Date: Mon, 6 Jan 2025 16:23:28 +0100
From: Jan Kara <jack@...e.cz>
To: Julian Sun <sunjunchao2870@...il.com>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, 
	tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, boyu.mt@...bao.com, 
	tm@....ma
Subject: Re: [PATCH 3/7] ext4: Don't set EXT4_STATE_MAY_INLINE_DATA for ea
 inodes

On Fri 20-12-24 23:16:21, Julian Sun wrote:
> Setting the EXT4_STATE_MAY_INLINE_DATA flag for ea inodes
> is meaningless because ea inodes do not use functions
> like ext4_write_begin().
> 
> Signed-off-by: Julian Sun <sunjunchao2870@...il.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/ialloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 7f1a5f90dbbd..49b112bfbd93 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1297,7 +1297,7 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap,
>  	ei->i_extra_isize = sbi->s_want_extra_isize;
>  	ei->i_inline_off = 0;
>  	if (ext4_has_feature_inline_data(sb) &&
> -	    (!(ei->i_flags & EXT4_DAX_FL) || S_ISDIR(mode)))
> +	    (!(ei->i_flags & (EXT4_DAX_FL|EXT4_EA_INODE_FL)) || S_ISDIR(mode)))
>  		ext4_set_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
>  	ret = inode;
>  	err = dquot_alloc_inode(inode);
> -- 
> 2.39.5
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR