linux-kernel - Re: [PATCH md-6.14 13/13] md/md-bitmap: support to build md-bitmap as kernel module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3v1ss2aMrCI5whs@infradead.org>
Date: Mon, 6 Jan 2025 07:24:34 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: Christoph Hellwig <hch@...radead.org>, xni@...hat.com, agk@...hat.com,
	snitzer@...nel.org, mpatocka@...hat.com, song@...nel.org,
	dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
	yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH md-6.14 13/13] md/md-bitmap: support to build md-bitmap
 as kernel module

On Mon, Jan 06, 2025 at 07:35:33PM +0800, Yu Kuai wrote:
> So there are total 6 existed helpers that I have to export, however,
> these are all historical burdens, md_cluster, raid1 slow disk, ...
> And I'm trying to get rid of them for the new md bitmap I'm working on.
> If you really don't like *module*, I can change the config to bool. :)

FYI, I really like your previous cleanups to better encapsulate the
bitmap code, and I'm also perfectly fine with a Kconfig options for it.

Also splitting existing code into modules has a tendency to break
distro initramfs magic frequently even with request_module in place.
So unless there is a really good reason I'd rather not do it.