linux-kernel - Re: [PATCH v7 2/3] netfilter: x_tables: Merge xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ppss971-6406-82q4-3371-1q8n9299qrq1@vanv.qr>
Date: Mon, 6 Jan 2025 16:27:49 +0100 (CET)
From: Jan Engelhardt <ej@...i.de>
To: Andrew Lunn <andrew@...n.ch>
cc: egyszeregy@...email.hu, fw@...len.de, pablo@...filter.org, 
    lorenzo@...nel.org, daniel@...earbox.net, leitao@...ian.org, 
    amiculas@...co.com, kadlec@...filter.org, davem@...emloft.net, 
    dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org, 
    pabeni@...hat.com, horms@...nel.org, netfilter-devel@...r.kernel.org, 
    coreteam@...filter.org, linux-kernel@...r.kernel.org, 
    netdev@...r.kernel.org
Subject: Re: [PATCH v7 2/3] netfilter: x_tables: Merge xt_*.c files which
 has same name.


On Monday 2025-01-06 15:22, Andrew Lunn wrote:
>> x86_64-before:
>> text    data     bss     dec     hex filename
>>  716     432       0    1148     47c xt_dscp.o
>> 1142     432       0    1574     626 xt_DSCP.o
>>  593     224       0     817     331 xt_hl.o
>>  934     224       0    1158     486 xt_HL.o
>> 1099     120       0    1219     4c3 xt_rateest.o
>> 2126     365       4    2495     9bf xt_RATEEST.o
>>  747     224       0     971     3cb xt_tcpmss.o
>> 2824     352       0    3176     c68 xt_TCPMSS.o
>> total data: 2373
>> 
>> x86_64-after:
>> text    data     bss     dec     hex filename
>> 1709     848       0    2557     9fd xt_dscp.o
>> 1352     448       0    1800     708 xt_hl.o
>> 3075     481       4    3560     de8 xt_rateest.o
>> 3423     576       0    3999     f9f xt_tcpmss.o
>> total data: 2353
>
>So you have saved 20 bytes in the data segment. A 0.8% reduction. If i
>was developing this patchset, when i see this number, i would
>immediately think, why am i bothering?

Before:
$ lsmod
xt_TCPMSS              12288  0
xt_tcpmss              12288  0

After:
$ lsmod
xt_tcpmss              12288  0

which is a 50% reduction in run-time memory use.