linux-kernel - Re: [PATCH v3] eth: fbnic: Revert "eth: fbnic: Add hardware monitoring support via HWMON interface"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250106073144.25d6b9fb@kernel.org>
Date: Mon, 6 Jan 2025 07:31:44 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Su Hui <suhui@...china.com>
Cc: alexanderduyck@...com, kernel-team@...a.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 jdelvare@...e.com, linux@...ck-us.net, michal.swiatkowski@...ux.intel.com,
 mohsin.bashr@...il.com, sanmanpradhan@...a.com, vadim.fedorenko@...ux.dev,
 kalesh-anakkur.purayil@...adcom.com, horms@...nel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-hwmon@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v3] eth: fbnic: Revert "eth: fbnic: Add hardware
 monitoring support via HWMON interface"

On Mon,  6 Jan 2025 10:36:48 +0800 Su Hui wrote:
> There is a garbage value problem in fbnic_mac_get_sensor_asic(). 'fw_cmpl'
> is uninitialized which makes 'sensor' and '*val' to be stored garbage
> value. Revert commit d85ebade02e8 ("eth: fbnic: Add hardware monitoring
> support via HWMON interface") to avoid this problem.
> 
> Fixes: d85ebade02e8 ("eth: fbnic: Add hardware monitoring support via HWMON interface")
> Signed-off-by: Su Hui <suhui@...china.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Suggested-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Thanks!