linux-kernel - Re: [PATCH 4/7] ext4: Introduce a new helper function ext4_generic_write_inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7nmpjvncdcywd6d3xxoobo3nvoj53gpm5jrjjummuega55qsf@lso74twq6fyz>
Date: Mon, 6 Jan 2025 16:35:15 +0100
From: Jan Kara <jack@...e.cz>
To: Julian Sun <sunjunchao2870@...il.com>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, 
	tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, boyu.mt@...bao.com, 
	tm@....ma
Subject: Re: [PATCH 4/7] ext4: Introduce a new helper function
 ext4_generic_write_inline_data()

On Fri 20-12-24 23:16:22, Julian Sun wrote:
> A new function, ext4_generic_write_inline_data(), is introduced
> to provide a generic implementation of the common logic found in
> ext4_da_write_inline_data_begin() and ext4_try_to_write_inline_data().
> 
> This function will be utilized in the subsequent two patches.
> 
> Signed-off-by: Julian Sun <sunjunchao2870@...il.com>

Looks good, just one style nit below. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

...
> +	*foliop = folio;
> +	up_read(&EXT4_I(inode)->xattr_sem);
> +	brelse(iloc.bh);
> +	return 1;

Here I'd suggest empty line for better readability.

> +out_release_folio:
> +	up_read(&EXT4_I(inode)->xattr_sem);
> +	folio_unlock(folio);
> +	folio_put(folio);
> +out_stop_journal:
> +	ext4_journal_stop(handle);
> +out_release_bh:
> +	brelse(iloc.bh);
> +	return ret;
> +}
> +

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR