linux-kernel - Re: [PATCH] Revert "mfd: axp20x: Allow multiple regulators"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250106154451.GB6763@google.com>
Date: Mon, 6 Jan 2025 15:44:51 +0000
From: Lee Jones <lee@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Chen-Yu Tsai <wens@...e.org>, linux-sunxi@...ts.linux.dev,
	Chris Morgan <macroalpha82@...il.com>,
	Vasily Khoruzhick <anarsoul@...il.com>,
	Jonathan Cameron <jic23@...nel.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "mfd: axp20x: Allow multiple regulators"

On Tue, 31 Dec 2024, Andre Przywara wrote:

> As Chris and Vasily reported, the attempt to support multiple AXP PMICs
> in one system [1] breaks some of the battery and charging functionality
> on devices with AXP PMICs. The reason is that the drivers now fail to get
> the correct IIO channel for the ADC component, as the current code seems
> to rely on the zero-based enumeration of the regulator devices.
> A fix is possible, but not trivial, as it requires some rework in the AXP
> MFD driver, which cannot be fully reviewed or tested in time for the
> 6.13 release.
> 
> So revert this patch for now, to avoid regressions on battery powered
> devices. This patch was really only necessary for devices with two
> PMICs, support for which is not mainline yet anyway, so we don't lose
> any functionality.
> 
> This reverts commit e37ec32188701efa01455b9be42a392adab06ce4.
> 
> [1] https://lore.kernel.org/linux-sunxi/20241007001408.27249-4-andre.przywara@arm.com/
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>
> ---
>  drivers/mfd/axp20x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 251465a656d09..5b8e88341a305 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -1445,7 +1445,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  		}
>  	}
>  
> -	ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_AUTO, axp20x->cells,
> +	ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
>  			      axp20x->nr_cells, NULL, 0, NULL);

Please submit a new patch and use PLATFORM_DEVID_NONE instead.

-- 
Lee Jones [李琼斯]